Gerrrr commented on code in PR #12535:
URL: https://github.com/apache/kafka/pull/12535#discussion_r949398138
##########
streams/src/main/java/org/apache/kafka/streams/kstream/internals/foreignkeyjoin/CombinedKey.java:
##########
@@ -38,8 +38,22 @@ public KP getPrimaryKey() {
return primaryKey;
}
- public boolean equals(final KF foreignKey, final KP primaryKey) {
- return this.foreignKey.equals(foreignKey) &&
this.primaryKey.equals(primaryKey);
+ @Override
+ public int hashCode() {
+ return Objects.hash(foreignKey, primaryKey);
+ }
Review Comment:
Both fields of `CombinedKey` are immutable:
https://github.com/apache/kafka/blob/2ff4c0a364379d231edfe1836042574359b1023e/streams/src/main/java/org/apache/kafka/streams/kstream/internals/foreignkeyjoin/CombinedKey.java#L22-L24
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
