mdedetrich commented on code in PR #12534: URL: https://github.com/apache/kafka/pull/12534#discussion_r949867626
########## core/src/main/scala/kafka/server/ControllerServer.scala: ########## @@ -78,18 +78,18 @@ class ControllerServer( val awaitShutdownCond = lock.newCondition() var status: ProcessStatus = SHUTDOWN - var linuxIoMetricsCollector: LinuxIoMetricsCollector = null - @volatile var authorizer: Option[Authorizer] = null - var tokenCache: DelegationTokenCache = null - var credentialProvider: CredentialProvider = null - var socketServer: SocketServer = null + var linuxIoMetricsCollector: LinuxIoMetricsCollector = _ + @volatile var authorizer: Option[Authorizer] = _ Review Comment: I just noticed this and maybe it makes sense to initialize this to `None` rather than `_`? Not sure if it would break anything but its definitely more idiomatic/correct. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
