jsancio commented on code in PR #12548:
URL: https://github.com/apache/kafka/pull/12548#discussion_r952058593
##########
clients/src/main/resources/common/message/DescribeQuorumResponse.json:
##########
@@ -38,7 +38,9 @@
"about": "The latest known leader epoch"},
{ "name": "HighWatermark", "type": "int64", "versions": "0+"},
Review Comment:
Does this return `-1` if the high watermark offset is not known? If so, how
about adding an about that explain this.
##########
clients/src/main/resources/common/message/DescribeQuorumResponse.json:
##########
@@ -38,7 +38,9 @@
"about": "The latest known leader epoch"},
{ "name": "HighWatermark", "type": "int64", "versions": "0+"},
{ "name": "CurrentVoters", "type": "[]ReplicaState", "versions": "0+"
},
- { "name": "Observers", "type": "[]ReplicaState", "versions": "0+" }
+ { "name": "Observers", "type": "[]ReplicaState", "versions": "0+" },
+ { "name": "HighWatermarkUpdateTimeMs", "type": "int64", "default": -1,
"tag": 0,
+ "taggedVersions": "1+", "ignorable": true, "about": "The wall clock
time that the high watermark was last updated on the leader" }
Review Comment:
This comment applies to all of the places where you added the `Ms` suffix.
Should it be `HighWatermarkUpdateTimestamp`? I was under the impression that
in Kafka the suffix `Timestamp` means wall clock time while the suffix `Ms`
means a duration or time span.
We should document that `-1` means that the high watermark update timestamp
is not know.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
