hachikuji commented on code in PR #12548:
URL: https://github.com/apache/kafka/pull/12548#discussion_r953178449
##########
raft/src/main/java/org/apache/kafka/raft/LeaderState.java:
##########
@@ -204,50 +198,80 @@ private boolean updateHighWatermark() {
return false;
}
+ private void setHighWatermark(
+ Optional<LogOffsetMetadata> newHighWatermark,
Review Comment:
Yeah, I think perhaps I can just revert this change. It made more sense when
the patch was also updating the update time.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]