cadonna commented on code in PR #12562:
URL: https://github.com/apache/kafka/pull/12562#discussion_r957076036
##########
streams/src/main/java/org/apache/kafka/streams/processor/internals/DefaultStateUpdater.java:
##########
@@ -100,7 +105,8 @@ public void run() {
} catch (final RuntimeException anyOtherException) {
handleRuntimeException(anyOtherException);
} finally {
- clear();
+ removeAddedTasksFromInputQueue();
+ removeUpdatingAndPausedTasks();
Review Comment:
Yeah, this is intentional. We need to close the task that are in the the
`restoredActiveTasks` queue. If I cleared that queue here, we would lose the
references to those tasks and we would not be able to ever close them. I have
an additional PR that moves the tasks from the output queues to the task
registry where they can be closed during the shutdown of the task manager.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
