cadonna commented on code in PR #12562:
URL: https://github.com/apache/kafka/pull/12562#discussion_r957095777
##########
streams/src/main/java/org/apache/kafka/streams/processor/internals/DefaultStateUpdater.java:
##########
@@ -557,7 +577,9 @@ public Set<Task> getRemovedTasks() {
}
public Set<Task> getPausedTasks() {
- return Collections.unmodifiableSet(new
HashSet<>(pausedTasks.values()));
+ return stateUpdaterThread != null
Review Comment:
This check only verifies that the state updater thread is running. If there
is no state updater running there cannot be tasks in restoration that can be
paused. Additionally -- and that is the main reason for this check -- we would
run into a `NullPointerException` when calling
`stateUpdaterThread.getPausedTasks()`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
