yashmayya opened a new pull request, #12568:
URL: https://github.com/apache/kafka/pull/12568

   - https://issues.apache.org/jira/browse/KAFKA-14015: A config provider 
(https://cwiki.apache.org/confluence/display/KAFKA/KIP-297%3A+Externalizing+Secrets+for+Connect+Configurations)
 that has dynamic reloading of secrets doesn't work as expected when Connect is 
run in standalone mode - i.e. tasks continue running with an older secret 
config value when the secret is rotated.
   - When a config provider needs to inform the herder that a connector needs 
to be restarted due to a change in a secret config that needs to be propagated 
to the connector and its tasks - it calls `Herder::restartConnector`
   - In the `DistributedHerder` implementation of `restartConnector` this works 
as expected where the connector is stopped, then started, and then if it's in 
the `STARTED` state at the end of startup - a task reconfiguration is 
requested. A task reconfiguration involves asking the connector to return a 
list of task configs (using the latest connector configs), comparing it with 
the running task configs and if a change is detected - write the new set of 
task configs to the config topic which will eventually result in the old set of 
tasks being stopped and a new set of tasks being brought up. 
   - In the `StandaloneHerder` implementation, however, the step of requesting 
task reconfiguration is missing. This PR aims to fix this which should solve 
the issue in https://issues.apache.org/jira/browse/KAFKA-14015


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to