yashmayya commented on code in PR #12568:
URL: https://github.com/apache/kafka/pull/12568#discussion_r962112024
##########
connect/runtime/src/test/java/org/apache/kafka/connect/runtime/standalone/StandaloneHerderTest.java:
##########
@@ -812,7 +861,7 @@ public void testPutConnectorConfig() throws Exception {
FutureCallback<Herder.Created<ConnectorInfo>> reconfigureCallback =
new FutureCallback<>();
herder.putConnectorConfig(CONNECTOR_NAME, newConnConfig, true,
reconfigureCallback);
Herder.Created<ConnectorInfo> newConnectorInfo =
reconfigureCallback.get(1000L, TimeUnit.SECONDS);
- ConnectorInfo newConnInfo = new ConnectorInfo(CONNECTOR_NAME,
newConnConfig, Arrays.asList(new ConnectorTaskId(CONNECTOR_NAME, 0)),
+ ConnectorInfo newConnInfo = new ConnectorInfo(CONNECTOR_NAME,
newConnConfig, singletonList(new ConnectorTaskId(CONNECTOR_NAME, 0)),
Review Comment:
Haha yeah I only did this so that my IDE stopped nagging me 😄
>it's easier to modify in case we need to add other elements, or construct
an empty list
Fair point, I've reverted this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
