C0urante commented on code in PR #12475: URL: https://github.com/apache/kafka/pull/12475#discussion_r957629873
########## checkstyle/.scalafmt.conf: ########## @@ -12,7 +12,10 @@ # WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. # See the License for the specific language governing permissions and # limitations under the License. -docstrings = JavaDoc +version = 3.5.9 Review Comment: Hmmm... it's a little strange that we now have to specify the version in two places (`gradle/dependencies.gradle` and `checkstyle/.scalafmt.conf`), and it might lead to some headaches when we want to upgrade to a newer version in the future. If there's no sane way to define the Scalafmt version in a single place (preferably `gradle/dependencies.gradle`), could we leave a comment in the dependencies file noting that the version will also have to be bumped in the Scalafmt configuration file? FWIW, I checked out the history for Scalafmt to see if we could get some additional context there, but the [PR](https://github.com/scalameta/scalafmt/pull/2843) that added the requirement for the `version` property didn't shed a lot of light. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
