mdedetrich commented on code in PR #12475:
URL: https://github.com/apache/kafka/pull/12475#discussion_r958078922


##########
checkstyle/.scalafmt.conf:
##########
@@ -12,7 +12,10 @@
 #  WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
 #  See the License for the specific language governing permissions and
 #  limitations under the License.
-docstrings = JavaDoc
+version = 3.5.9

Review Comment:
   So I found the release notes where this change was added, i.e. 
https://github.com/scalameta/scalafmt/releases/tag/v3.1.0 but unfortunately its 
not very informative as to why the version now has to be explicit.
   
   In any case I have rebased the PR by adding a comment notifying that 
whenever `scalafmt` is bumped in `dependencies.gradle` that it also needs to be 
changed in `checkstyle/.scalafmt.conf`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to