jsancio commented on PR #12414: URL: https://github.com/apache/kafka/pull/12414#issuecomment-1233255286
> Hi @jsancio, I have reverted the changes made to `RaftClient` and kept the logging withing `BrokerMetadataSnapshotter` and `QuorumController` > > I have two questions, would really be helpful if you could guide me on this - > > 1. We also take a snapshot in `org.apache.kafka.raft` within the class `ReplicatedCounter` under the `handleCommit` function. > I am facing an issue in being able to import the `SnapshotReason` from the `metadata/src/main/java/org/apache/kafka/metadata/util` package. Could you guide me on how I could fix this? `ReplicatedCounter` is mainly used to test the KRaft implementation. We should probably consider moving this type to `raft/src/test`. > > 2. We take snapshots at two different places within `QuorumController` - One I was able to figure out the reason being `MaxBytesExceeded`. There is another function `beginWritingSnapshot` which also initiates a snapshot - I was not able to figure out who calls this function and what would the reason be in this scenario? It looks like this method is only used by tests. I think it is okay for this to have an "unknown reason" for now. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
