ashmeet13 commented on code in PR #12414:
URL: https://github.com/apache/kafka/pull/12414#discussion_r960902453


##########
core/src/main/scala/kafka/server/metadata/MetadataSnapshotter.scala:
##########
@@ -31,5 +32,5 @@ trait MetadataSnapshotter {
    *
    * @return                      True if we will write out a new snapshot; 
false otherwise.
    */
-  def maybeStartSnapshot(lastContainedLogTime: Long, image: MetadataImage): 
Boolean
+  def maybeStartSnapshot(lastContainedLogTime: Long, image: MetadataImage, 
reason: Set[SnapshotReason]): Boolean

Review Comment:
   Added the `reason` as a `param` in the documentation. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to