hachikuji commented on code in PR #12669:
URL: https://github.com/apache/kafka/pull/12669#discussion_r978171607
##########
core/src/test/scala/integration/kafka/api/PlaintextAdminIntegrationTest.scala:
##########
@@ -169,8 +168,7 @@ class PlaintextAdminIntegrationTest extends
BaseAdminIntegrationTest {
waitForTopics(client, expectedPresent = topics, expectedMissing = List())
val controller = brokers.find(_.config.brokerId ==
brokers.flatMap(_.metadataCache.getControllerId).head).get
- controller.shutdown()
- controller.awaitShutdown()
+ killBroker(controller.config.brokerId)
Review Comment:
The point of this test is a little unclear to me. We have already verified
metadata propagation in the `waitForTopics` above. Not sure why killing the
controller would change that. Anyway, perhaps a more accurate name for the test
would be something like `testCreatedTopicStillVisibleAfterControllerChange`? I
feel like we could also just delete the test since it is probably covered by
every integration test which kills the controller.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
