hachikuji commented on code in PR #12669:
URL: https://github.com/apache/kafka/pull/12669#discussion_r981539256
##########
core/src/test/scala/integration/kafka/api/PlaintextAdminIntegrationTest.scala:
##########
@@ -169,8 +168,7 @@ class PlaintextAdminIntegrationTest extends
BaseAdminIntegrationTest {
waitForTopics(client, expectedPresent = topics, expectedMissing = List())
val controller = brokers.find(_.config.brokerId ==
brokers.flatMap(_.metadataCache.getControllerId).head).get
- controller.shutdown()
- controller.awaitShutdown()
+ killBroker(controller.config.brokerId)
Review Comment:
The value of the test still seems questionable to me. The call
`waitForTopics` ensures metadata propagation to at least one broker. The call
to `describeTopics` below after we have killed the controller is very likely to
hit the same broker because the admin client biases toward open connections. A
better test of metadata durability would probably kill all brokers and restart
them. Anyway, we don't need to fix that here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
