nicktelford commented on code in PR #12393:
URL: https://github.com/apache/kafka/pull/12393#discussion_r989161053
##########
streams/src/main/java/org/apache/kafka/streams/processor/internals/StateManagerUtil.java:
##########
@@ -115,7 +115,7 @@ static void closeStateManager(final Logger log,
final StateDirectory stateDirectory,
final TaskType taskType) {
// if EOS is enabled, wipe out the whole state store for unclean close
since it is now invalid
- final boolean wipeStateStore = !closeClean && eosEnabled;
+ final boolean wipeStateStore = !closeClean && eosEnabled &&
stateMgr.transactional();
Review Comment:
Shouldn't this be `&& !stateMgr.transactional()`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
