nicktelford commented on code in PR #12393:
URL: https://github.com/apache/kafka/pull/12393#discussion_r1008188697
##########
streams/src/test/java/org/apache/kafka/streams/integration/EOSUncleanShutdownIntegrationTest.java:
##########
@@ -73,16 +75,25 @@ public class EOSUncleanShutdownIntegrationTest {
@SuppressWarnings("deprecation")
@Parameterized.Parameters(name = "{0}")
- public static Collection<String[]> data() {
- return Arrays.asList(new String[][] {
- {StreamsConfig.EXACTLY_ONCE},
- {StreamsConfig.EXACTLY_ONCE_V2}
- });
+ public static Collection<Object[]> data() {
+ final List<String> eosConfigs = Arrays.asList(
+ StreamsConfig.EXACTLY_ONCE,
+ StreamsConfig.EXACTLY_ONCE_V2
+ );
+ final List<Object[]> data = new ArrayList<>(eosConfigs.size() * 2);
+ for (final String eosConfig : eosConfigs) {
+ //data.add(new Object[] {eosConfig, false});
+ data.add(new Object[] {eosConfig, true});
Review Comment:
Looks like you intended for this test to be parameterized for both
transactional and non-transactional stores, but have not yet completed it?
##########
streams/src/test/java/org/apache/kafka/streams/integration/EOSUncleanShutdownIntegrationTest.java:
##########
@@ -115,6 +126,9 @@ public void
shouldWorkWithUncleanShutdownWipeOutStateStore() throws InterruptedE
final String appId = "shouldWorkWithUncleanShutdownWipeOutStateStore";
STREAMS_CONFIG.put(StreamsConfig.APPLICATION_ID_CONFIG, appId);
STREAMS_CONFIG.put(StreamsConfig.PROCESSING_GUARANTEE_CONFIG,
eosConfig);
+ if (stateStoreTransactional) {
Review Comment:
Does this test make sense when the state stores are transactional, since
transactional state isn't wiped on unclean shutdown?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
