vamossagar12 commented on code in PR #12758:
URL: https://github.com/apache/kafka/pull/12758#discussion_r1000836229
##########
streams/src/main/java/org/apache/kafka/streams/state/internals/NamedCache.java:
##########
@@ -182,6 +189,7 @@ synchronized void put(final Bytes key, final LRUCacheEntry
value) {
dirtyKeys.add(key);
}
currentSizeBytes += node.size();
+ totalCacheSizeSensor.record(currentSizeBytes);
Review Comment:
haha i would also agree with you given how my streams PRs have fared. I
removed the metrics bit.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
