vamossagar12 commented on code in PR #12758:
URL: https://github.com/apache/kafka/pull/12758#discussion_r1000840656
##########
streams/src/main/java/org/apache/kafka/streams/internals/StreamsConfigUtils.java:
##########
@@ -66,4 +73,28 @@ public static boolean eosEnabled(final ProcessingMode
processingMode) {
return processingMode == ProcessingMode.EXACTLY_ONCE_ALPHA ||
processingMode == ProcessingMode.EXACTLY_ONCE_V2;
}
+
+ @SuppressWarnings("deprecation")
+ public static long getTotalCacheSize(final StreamsConfig config) {
Review Comment:
Thanks for the suggestion. I did think about this but the `TopologyConfig`
has some more logic to check for override and is based on that when deciding
which value to use. So, I felt the caller logic might get complex and hence
left it as is. Do you think that makes sense?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
