cadonna commented on PR #12809:
URL: https://github.com/apache/kafka/pull/12809#issuecomment-1298534383

   @clolov Thank you for the PR!
   
   That seems a tricky one. Actually, we cannot simply remove methods from that 
class. It is true that they are not used within our code base. However, the 
options are directly exposed to the users as public APIs via 
`RocksDBConfigSetter`. If we just remove some methods, we might break backwards 
compatibility.
   
   What alternatives do we have?
   
   1. RocksDB 7.1.2 seems to be the earliest RocksDB version that uses the 
fixed zlib library 1.2.12. We could ask RocksDB developers if they could 
release a 6.29.x with zlib 1.2.12.
   
   2. We could not delete the methods, not forward the calls and log a warn 
message.
   
   3. We could break backwards compatibility since fixing a CVE might be of 
higher priority.
   
   What else?
   
   \cc  @ableegoldman 
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to