cadonna commented on code in PR #12809:
URL: https://github.com/apache/kafka/pull/12809#discussion_r1017938045
##########
streams/src/main/java/org/apache/kafka/streams/state/internals/RocksDBGenericOptionsToDbOptionsColumnFamilyOptionsAdapter.java:
##########
@@ -610,15 +617,21 @@ public AccessHint accessHintOnCompactionStart() {
return dbOptions.accessHintOnCompactionStart();
}
- @Override
+ @Deprecated
public Options setNewTableReaderForCompactionInputs(final boolean
newTableReaderForCompactionInputs) {
-
dbOptions.setNewTableReaderForCompactionInputs(newTableReaderForCompactionInputs);
+ String message = "This method has been removed from the underlying
RocksDB. " +
+ "It was not affecting compaction even in earlier versions. " +
+ "It is currently a no-op method.";
+ log.warn(message);
return this;
}
- @Override
+ @Deprecated
public boolean newTableReaderForCompactionInputs() {
- return dbOptions.newTableReaderForCompactionInputs();
+ String message = "This method has been removed from the underlying
RocksDB. " +
+ "It is now a method which always return false.";
Review Comment:
```suggestion
"It is now a method which always returns false.";
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
