philipnee commented on code in PR #12832:
URL: https://github.com/apache/kafka/pull/12832#discussion_r1023219364
##########
clients/src/main/java/org/apache/kafka/clients/consumer/internals/SubscriptionState.java:
##########
@@ -47,7 +47,7 @@
import java.util.function.Predicate;
import java.util.regex.Pattern;
-import static
org.apache.kafka.clients.consumer.internals.Fetcher.hasUsableOffsetForLeaderEpochVersion;
+import static
org.apache.kafka.clients.consumer.internals.DefaultFetcher.hasUsableOffsetForLeaderEpochVersion;
Review Comment:
Can we move this to a different class, perhaps a static class like
FetcherUtil?
##########
clients/src/main/java/org/apache/kafka/clients/consumer/internals/DefaultFetcher.java:
##########
@@ -130,7 +130,7 @@
* on a different thread.</li>
* </ul>
*/
-public class Fetcher<K, V> implements Closeable {
+public class DefaultFetcher<K, V> implements Closeable {
Review Comment:
I'm thinking if we aren't implementing an interface, do we actually need to
rename the class? Also because the implementation would be significantly
different from the current fetcher, I wonder if there will be a common
interface to implement.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
