kirktrue commented on code in PR #12832:
URL: https://github.com/apache/kafka/pull/12832#discussion_r1028332650
##########
clients/src/main/java/org/apache/kafka/clients/consumer/internals/DefaultFetcher.java:
##########
@@ -130,7 +130,7 @@
* on a different thread.</li>
* </ul>
*/
-public class Fetcher<K, V> implements Closeable {
+public class DefaultFetcher<K, V> implements Closeable {
Review Comment:
There is a common set of methods to implement.
The reason this is being done this way is to avoid a large set of diffs.
Steps:
1. Rename `Fetcher` to `DefaultFetcher`
2. Extract the common methods into an interface named `Fetcher`
3. Retcon `DefaultFetcher` (the original `Fetcher`) to implement the
`Fetcher` interface
4. Add the `ProtoFetcher` (for use by the new, refactored consumer`) to
implement the `Fetcher` interface
5. Generalize the fetcher tests to use the interface and add subclasses that
test the specific implementations
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
