jolshan commented on code in PR #12845:
URL: https://github.com/apache/kafka/pull/12845#discussion_r1023261160
##########
core/src/main/scala/kafka/server/KafkaApis.scala:
##########
@@ -1646,73 +1649,46 @@ class KafkaApis(val requestChannel: RequestChannel,
}
}
+ private def makeGroupCoordinatorRequestContextFrom(
+ request: RequestChannel.Request,
+ requestLocal: RequestLocal
+ ): GroupCoordinatorRequestContext = {
+ new GroupCoordinatorRequestContext(
+ request.context.header.data.requestApiVersion,
+ request.context.header.data.clientId,
+ request.context.clientAddress,
+ requestLocal.bufferSupplier
+ )
+ }
+
def handleJoinGroupRequest(request: RequestChannel.Request, requestLocal:
RequestLocal): Unit = {
val joinGroupRequest = request.body[JoinGroupRequest]
- // the callback for sending a join-group response
- def sendResponseCallback(joinResult: JoinGroupResult): Unit = {
- def createResponse(requestThrottleMs: Int): AbstractResponse = {
- val protocolName = if (request.context.apiVersion() >= 7)
- joinResult.protocolName.orNull
- else
- joinResult.protocolName.getOrElse(GroupCoordinator.NoProtocol)
-
- val responseBody = new JoinGroupResponse(
- new JoinGroupResponseData()
Review Comment:
Looks like we've also simplified building the response.
##########
core/src/main/scala/kafka/server/KafkaApis.scala:
##########
@@ -1646,73 +1649,46 @@ class KafkaApis(val requestChannel: RequestChannel,
}
}
+ private def makeGroupCoordinatorRequestContextFrom(
+ request: RequestChannel.Request,
+ requestLocal: RequestLocal
+ ): GroupCoordinatorRequestContext = {
+ new GroupCoordinatorRequestContext(
+ request.context.header.data.requestApiVersion,
+ request.context.header.data.clientId,
+ request.context.clientAddress,
+ requestLocal.bufferSupplier
+ )
+ }
+
def handleJoinGroupRequest(request: RequestChannel.Request, requestLocal:
RequestLocal): Unit = {
val joinGroupRequest = request.body[JoinGroupRequest]
- // the callback for sending a join-group response
- def sendResponseCallback(joinResult: JoinGroupResult): Unit = {
- def createResponse(requestThrottleMs: Int): AbstractResponse = {
- val protocolName = if (request.context.apiVersion() >= 7)
- joinResult.protocolName.orNull
- else
- joinResult.protocolName.getOrElse(GroupCoordinator.NoProtocol)
-
- val responseBody = new JoinGroupResponse(
- new JoinGroupResponseData()
Review Comment:
Looks like we've also simplified building the response. Looks good.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
