dajac commented on code in PR #12845: URL: https://github.com/apache/kafka/pull/12845#discussion_r1023603789
########## core/src/test/scala/unit/kafka/server/KafkaApisTest.scala: ########## @@ -2524,196 +2528,166 @@ class KafkaApisTest { assertEquals(MemoryRecords.EMPTY, FetchResponse.recordsOrFail(partitionData)) } - @Test - def testJoinGroupProtocolsOrder(): Unit = { Review Comment: Right. Let me fix it. ########## core/src/test/scala/unit/kafka/server/KafkaApisTest.scala: ########## @@ -2524,196 +2528,166 @@ class KafkaApisTest { assertEquals(MemoryRecords.EMPTY, FetchResponse.recordsOrFail(partitionData)) } - @Test - def testJoinGroupProtocolsOrder(): Unit = { Review Comment: This test's logic is now tested in `GroupCoordinatorAdaptorTest`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org