gharris1727 commented on PR #12805: URL: https://github.com/apache/kafka/pull/12805#issuecomment-1322880268
@C0urante I've refactored the `hideFromPluginPath` and `pluginPath(TestPlugin)` functionality to hopefully resolve the awkwardness of both when dealing with default/non-default plugins. the `hideFromPluginPath` flag is now inverted to `includeByDefault`, and most plugins are marked to be included in the default plugin path. The default plugin.path is returned by `pluginPath()` with no arguments, and custom plugin.paths can be assembled by calling `pluginPath(TestPlugin...)` with all of the relevant plugins. I've also simplified the error handling of pluginPath/pluginClasses by having them assert the integrity of the PLUGIN_JARS. Upon reflecting on the previous design, it was silly not to assert the integrity when using the variable, and force the caller to propagate errors explicitly. These two changes should obviate the need for any error handling for a `pluginPath(singlePluginConstant)` call. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
