[GitHub] [kafka] rondagostino commented on a diff in pull request #12856: KAFKA-14392: KRaft broker heartbeat timeout should not exceed broker.session.timeout.ms

[GitBox]

rondagostino commented on code in PR #12856:
URL: https://github.com/apache/kafka/pull/12856#discussion_r1029683189


##########
core/src/main/scala/kafka/server/AlterPartitionManager.scala:
##########
@@ -91,7 +91,8 @@ object AlterPartitionManager {
       config = config,
       channelName = "alterPartition",
       threadNamePrefix = threadNamePrefix,
-      retryTimeoutMs = Long.MaxValue
+      networkClientRetryTimeoutMs = if (config.processRoles.isEmpty) 
config.controllerSocketTimeoutMs else config.brokerSessionTimeoutMs / 2,

Review Comment:
   I believe https://issues.apache.org/jira/browse/KAFKA-14394 can now be 
closed.  We do want infinite retries on the broker side for AlterPartition 
requests as per https://github.com/apache/kafka/pull/9564#discussion_r527326231.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org