[GitHub] [kafka] cmccabe commented on a diff in pull request #12856: KAFKA-14392: KRaft broker heartbeat timeout should not exceed broker.session.timeout.ms

[GitBox]

cmccabe commented on code in PR #12856:
URL: https://github.com/apache/kafka/pull/12856#discussion_r1044929305


##########
core/src/main/scala/kafka/server/BrokerToControllerChannelManager.scala:
##########
@@ -211,7 +211,7 @@ class BrokerToControllerChannelManagerImpl(
         50,
         Selectable.USE_DEFAULT_BUFFER_SIZE,
         Selectable.USE_DEFAULT_BUFFER_SIZE,
-        config.requestTimeoutMs,
+        Math.min(Int.MaxValue, Math.min(config.controllerSocketTimeoutMs, 
retryTimeoutMs)).toInt, // request timeout should not exceed the provided retry 
timeout

Review Comment:
   ok, that's fair.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org