gharris1727 commented on code in PR #12802:
URL: https://github.com/apache/kafka/pull/12802#discussion_r1037326575
##########
connect/runtime/src/main/java/org/apache/kafka/connect/runtime/distributed/DistributedHerder.java:
##########
@@ -1645,6 +1646,8 @@ private void startAndStop(Collection<Callable<Void>>
callables) {
startAndStopExecutor.invokeAll(callables);
} catch (InterruptedException e) {
// ignore
+ } catch (RejectedExecutionException re) {
+ log.error("startAndStopExecutor already shutdown or full. Not
invoking explicit connector/task shutdown");
Review Comment:
@vamossagar12 Sorry for the ambiguous JIRA description. I should have made
it more explicit what the bug was beyond the title of the ticket.
Yes, you are correct in observing that one negative effect of this bug is
that the remaining portions of the halt aren't completed reliably, and that is
definitely something that should be improved. That can either be fixed by
catching the exception (what you've implemented) or preventing the exception.
If you prevent the exception, you also fix the other negative effect of the
bug, which is that connector stop() methods are never called. That is the
effect that I described in the title, and the more important aspect that this
PR must resolve.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
