vamossagar12 commented on code in PR #12802:
URL: https://github.com/apache/kafka/pull/12802#discussion_r1041307783
##########
connect/runtime/src/main/java/org/apache/kafka/connect/runtime/distributed/DistributedHerder.java:
##########
@@ -1645,6 +1646,8 @@ private void startAndStop(Collection<Callable<Void>>
callables) {
startAndStopExecutor.invokeAll(callables);
} catch (InterruptedException e) {
// ignore
+ } catch (RejectedExecutionException re) {
+ log.error("startAndStopExecutor already shutdown or full. Not
invoking explicit connector/task shutdown");
Review Comment:
Thanks @C0urante . I see what you mean here. I guess if we are to give a
higher timeout to `erderExecutor::awaitTermination`, that needs an update to
the worker config `task.shutdown.graceful.timeout.ms
` which is defaulted to 5s. Are you suggesting to increase the default. I
would have thought would need a KIP for this considering it's a public
interface. Or maybe I am wrong.
Also, I was going through this KIP of yours:
https://cwiki.apache.org/confluence/display/KAFKA/KIP-611%3A+Improved+Handling+of+Abandoned+Connectors+and+Tasks
and it seems to suggest:
```
The task.shutdown.graceful.timeout.ms property will be deprecated and
scheduled for removal at the next major release. At the time of writing, the
next major release is 3.0.
```
but that doesnt seem to be the case. Am I missing something here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
