jsancio commented on code in PR #12963:
URL: https://github.com/apache/kafka/pull/12963#discussion_r1042828301
##########
core/src/test/scala/unit/kafka/utils/TestUtils.scala:
##########
@@ -1230,7 +1230,7 @@ object TestUtils extends Logging {
TestUtils.waitUntilTrue(
() => {
brokers.forall { broker =>
- val metadataOffset =
broker.asInstanceOf[BrokerServer].metadataPublisher.publishedOffset
+ val metadataOffset =
broker.asInstanceOf[BrokerServer].metadataPublisher.publishedEndOffset
metadataOffset >= controllerOffset
Review Comment:
We could also maybe rename `metadataOffset` to `metadataEndOffset`.
I think we discussed this in the past but I wonder we should use types like
`Offset` and `EndOffset` instead of `long` and implement comparison logic for
them. Java's future primitive classes would be ideal for this:
https://openjdk.org/jeps/401
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
