jsancio commented on code in PR #12963:
URL: https://github.com/apache/kafka/pull/12963#discussion_r1044748464
##########
core/src/test/scala/unit/kafka/server/metadata/BrokerMetadataListenerTest.scala:
##########
@@ -166,15 +172,15 @@ class BrokerMetadataListenerTest {
image = newImage
}
- override def publishedOffset: Long = -1
+ override def publishedEndOffset: Long = -1
}
private val FOO_ID = Uuid.fromString("jj1G9utnTuCegi_gpnRgYw")
private val BAR_ID = Uuid.fromString("SzN5j0LvSEaRIJHrxfMAlg")
private def generateManyRecords(listener: BrokerMetadataListener,
endOffset: Long): Unit = {
Review Comment:
Got it. The part that I don't understand is that we send that value
(`endOffset`) to `mockBatchReader` in the first parameter (`lastOffset`).
Looking at the implementation of `mockBatchReader`, it looks to me like that
code assumes that the offset is inclusive.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
