akhileshchg commented on code in PR #12961:
URL: https://github.com/apache/kafka/pull/12961#discussion_r1050028258
##########
core/src/main/scala/kafka/server/BrokerToControllerChannelManager.scala:
##########
@@ -276,17 +290,38 @@ case class BrokerToControllerQueueItem(
)
class BrokerToControllerRequestThread(
- networkClient: KafkaClient,
+ networkClientFactory: ControllerInformation => KafkaClient,
metadataUpdater: ManualMetadataUpdater,
controllerNodeProvider: ControllerNodeProvider,
config: KafkaConfig,
time: Time,
threadName: String,
retryTimeoutMs: Long
-) extends InterBrokerSendThread(threadName, networkClient,
Math.min(Int.MaxValue, Math.min(config.controllerSocketTimeoutMs,
retryTimeoutMs)).toInt, time, isInterruptible = false) {
+) extends InterBrokerSendThread(threadName, null, Math.min(Int.MaxValue,
Math.min(config.controllerSocketTimeoutMs, retryTimeoutMs)).toInt, time,
isInterruptible = false) {
Review Comment:
I thought about this. This unnecessarily changes all the other
implementations and places where InterBrokerSendThread. Let me know your
thoughts.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
