cmccabe commented on code in PR #12961: URL: https://github.com/apache/kafka/pull/12961#discussion_r1046450254
########## core/src/main/scala/kafka/server/KafkaConfig.scala: ########## @@ -1665,6 +1665,7 @@ class KafkaConfig private(doLog: Boolean, val props: java.util.Map[_, _], dynami def usesSelfManagedQuorum: Boolean = processRoles.nonEmpty val migrationEnabled: Boolean = getBoolean(KafkaConfig.MigrationEnabledProp) + def enableZkApiForwarding: Boolean = migrationEnabled && interBrokerProtocolVersion.isApiForwardingEnabled Review Comment: to clarify, it's fine to do this static check for now but it should be done in `Kafka.scala` and we should comment that it's OK because IBP is static in ZK mode -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
