satishd commented on code in PR #13043:
URL: https://github.com/apache/kafka/pull/13043#discussion_r1063067362
##########
core/src/test/scala/unit/kafka/log/LogSegmentTest.scala:
##########
@@ -354,9 +356,10 @@ class LogSegmentTest {
// recover again, but this time assuming the transaction from pid2 began
on a previous segment
stateManager = newProducerStateManager()
- stateManager.loadProducerEntry(new ProducerStateEntry(pid2,
- mutable.Queue[BatchMetadata](BatchMetadata(10, 10L, 5,
RecordBatch.NO_TIMESTAMP)), producerEpoch,
- 0, RecordBatch.NO_TIMESTAMP, Some(75L)))
+ val batchMetadata = new util.ArrayList[BatchMetadata]()
Review Comment:
ArrayList constructor does not allow passing a single instance like
mutable.Queue. Anyways this is changed to Collections.singletonList in the
latest code. I saw your suggestion to remove this List and take single instance
directly. I will reply to your comment there.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
