satishd commented on code in PR #13043: URL: https://github.com/apache/kafka/pull/13043#discussion_r1063066837
########## storage/src/main/java/org/apache/kafka/server/log/internals/TxnMetadata.java: ########## @@ -0,0 +1,70 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.kafka.server.log.internals; + +import java.util.Objects; +import java.util.OptionalLong; + +public final class TxnMetadata { + public final long producerId; + public final LogOffsetMetadata firstOffset; + public OptionalLong lastOffset; + + public TxnMetadata(long producerId, + LogOffsetMetadata firstOffset, + OptionalLong lastOffset) { + this.producerId = producerId; + this.firstOffset = firstOffset; + this.lastOffset = lastOffset; + } + public TxnMetadata(long producerId, long firstOffset) { + this(producerId, new LogOffsetMetadata(firstOffset)); + } + + public TxnMetadata(long producerId, LogOffsetMetadata firstOffset) { + this(producerId, firstOffset, OptionalLong.empty()); + } + + @Override + public boolean equals(Object o) { + if (this == o) return true; + if (o == null || getClass() != o.getClass()) return false; + + TxnMetadata that = (TxnMetadata) o; + + if (producerId != that.producerId) return false; + if (!Objects.equals(firstOffset, that.firstOffset)) return false; + return Objects.equals(lastOffset, that.lastOffset); Review Comment: I avoid non final fields usage in equals/hashcode implementations. I should have left a comment in the code on why these methods were added. I tried to keep similar semantics like case classes in Scala as earlier. Afaik, it does all the fields eq(reference checks) as the default implementation. `TxnMetadata` is used as a value of `TreeMap` in ProducerStateManager. Currently, I do not see any usages in map#containsValue in that. So, I prefer to avoid implementing it for now as you suggested. But the existing tests have equality assertions with `TxnMetadata`, one way to address them is to have the equality assertions for producer id and offsetmetadata. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
