jolshan commented on code in PR #13112: URL: https://github.com/apache/kafka/pull/13112#discussion_r1072842347
########## core/src/main/scala/kafka/server/KafkaApis.scala: ########## @@ -357,8 +354,9 @@ class KafkaApis(val requestChannel: RequestChannel, new UpdateMetadataResponse(new UpdateMetadataResponseData().setErrorCode(Errors.STALE_BROKER_EPOCH.code))) } else { val deletedPartitions = replicaManager.maybeUpdateMetadataCache(correlationId, updateMetadataRequest) - if (deletedPartitions.nonEmpty) - groupCoordinator.handleDeletedPartitions(deletedPartitions, requestLocal) + if (deletedPartitions.nonEmpty) { + groupCoordinator.onPartitionsDeleted(deletedPartitions.asJava, requestLocal.bufferSupplier) Review Comment: I see in this method we convert back to scala. Is there a way to avoid? 😅 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org