[GitHub] [kafka] jolshan commented on a diff in pull request #13112: KAFKA-14367; Add internal APIs to the new `GroupCoordinator` interface

[GitBox]

jolshan commented on code in PR #13112:
URL: https://github.com/apache/kafka/pull/13112#discussion_r1072855094


##########
core/src/main/scala/kafka/server/KafkaApis.scala:
##########
@@ -310,9 +307,9 @@ class KafkaApis(val requestChannel: RequestChannel,
           if (topicPartition.topic == GROUP_METADATA_TOPIC_NAME
               && partitionState.deletePartition) {
             val leaderEpoch = if (partitionState.leaderEpoch >= 0)
-              Some(partitionState.leaderEpoch)

Review Comment:
   Ah I see the interface is java. Are we planning to move everything to Java 
though? It's a bit tricky since the GroupCoordinatorAdaptor was done in scala.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org