cmccabe commented on code in PR #13183:
URL: https://github.com/apache/kafka/pull/13183#discussion_r1094918202
##########
metadata/src/main/java/org/apache/kafka/metadata/migration/KRaftMigrationDriver.java:
##########
@@ -538,12 +553,23 @@ public void run() throws Exception {
// TODO: Unhappy path: Probably relinquish leadership and let
new controller
// retry the write?
- log.trace("Sending RPCs to brokers for metadata {}.",
metadataType);
- propagator.sendRPCsToBrokersFromMetadataDelta(delta, image,
- migrationLeadershipState.zkControllerEpoch());
+ if (delta.topicsDelta() != null || delta.clusterDelta() !=
null) {
+ log.trace("Sending RPCs to brokers for metadata {}.",
metadataType);
+ propagator.sendRPCsToBrokersFromMetadataDelta(delta, image,
+ migrationLeadershipState.zkControllerEpoch());
+ } else {
+ log.trace("Not sending RPCs to brokers for metadata {}
since no relevant metadata changes", metadataType);
Review Comment:
nitpick: perhaps "since no relevant metadata has changd"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
