cmccabe commented on code in PR #13183:
URL: https://github.com/apache/kafka/pull/13183#discussion_r1094930020
##########
server-common/src/main/java/org/apache/kafka/queue/KafkaEventQueue.java:
##########
@@ -250,7 +250,7 @@ private void handleEvents() throws InterruptedException {
continue;
} else if (shuttingDown) {
remove(eventContext);
- toDeliver = new TimeoutException();
+ toDeliver = new QueueClosingException();
Review Comment:
I think `RejectedExecutionException` really is more appropriate. If you
tried to schedule (or reschedule) a deferred task and the queue was shut down,
you'd get `RejectedExecutionException` already. So you already have to catch
REE and treat it this way.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
