satishd commented on code in PR #13046: URL: https://github.com/apache/kafka/pull/13046#discussion_r1096704547
########## storage/src/main/java/org/apache/kafka/server/log/internals/CheckpointFileWithFailureHandler.java: ########## @@ -0,0 +1,62 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.kafka.server.log.internals; + +import org.apache.kafka.common.errors.KafkaStorageException; +import org.apache.kafka.server.common.CheckpointFile; + +import java.io.File; +import java.io.IOException; +import java.util.Collection; +import java.util.List; + +public class CheckpointFileWithFailureHandler<T> { + + public final File file; + private final LogDirFailureChannel logDirFailureChannel; + private final String logDir; + + private final CheckpointFile<T> checkpointFile; + + public CheckpointFileWithFailureHandler(File file, int version, CheckpointFile.EntryFormatter<T> formatter, + LogDirFailureChannel logDirFailureChannel, String logDir) throws IOException { + this.file = file; + this.logDirFailureChannel = logDirFailureChannel; + this.logDir = logDir; + checkpointFile = new CheckpointFile<>(file, version, formatter); Review Comment: Each checkpoint file does not need to be treated the same. Whichever checkpoint file needs to treat these errors as disk failure will use the handler. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
