satishd commented on code in PR #13046: URL: https://github.com/apache/kafka/pull/13046#discussion_r1096705686
########## storage/src/main/java/org/apache/kafka/storage/internals/checkpoint/LeaderEpochCheckpointFile.java: ########## @@ -0,0 +1,83 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.kafka.storage.internals.checkpoint; + +import org.apache.kafka.server.common.CheckpointFile.EntryFormatter; +import org.apache.kafka.server.log.internals.CheckpointFileWithFailureHandler; +import org.apache.kafka.server.log.internals.EpochEntry; +import org.apache.kafka.server.log.internals.LogDirFailureChannel; + +import java.io.File; +import java.io.IOException; +import java.util.Collection; +import java.util.List; +import java.util.Optional; +import java.util.regex.Pattern; + +/** + * This class persists a map of (LeaderEpoch => Offsets) to a file (for a certain replica) + * <p> + * The format in the LeaderEpoch checkpoint file is like this: + * -----checkpoint file begin------ + * 0 <- LeaderEpochCheckpointFile.currentVersion + * 2 <- following entries size + * 0 1 <- the format is: leader_epoch(int32) start_offset(int64) + * 1 2 + * -----checkpoint file end---------- + */ +public class LeaderEpochCheckpointFile implements LeaderEpochCheckpoint { + + public static final Formatter FORMATTER = new Formatter(); + + private static final String LEADER_EPOCH_CHECKPOINT_FILENAME = "leader-epoch-checkpoint"; + private static final Pattern WHITE_SPACES_PATTERN = Pattern.compile("\\s+"); + private static final int CURRENT_VERSION = 0; + + private final CheckpointFileWithFailureHandler<EpochEntry> checkpoint; + + public LeaderEpochCheckpointFile(File file, LogDirFailureChannel logDirFailureChannel) throws IOException { + checkpoint = new CheckpointFileWithFailureHandler<>(file, CURRENT_VERSION, FORMATTER, logDirFailureChannel, file.getParentFile().getParent()); + } + + public LeaderEpochCheckpointFile(File file) throws IOException { + this(file, null); Review Comment: Good catch! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
