[GitHub] [kafka] ijuma commented on a diff in pull request #13213: KAFKA-14688 Move package org.apache.kafka.server.log.internals to org.apache.kafka.storage.internals.log

[via GitHub]

ijuma commented on code in PR #13213:
URL: https://github.com/apache/kafka/pull/13213#discussion_r1098655061


##########
storage/src/main/java/org/apache/kafka/storage/internals/log/AbstractIndex.java:
##########
@@ -64,8 +65,7 @@ private enum SearchResultType {
      */
     private volatile int maxEntries;
     /** The number of entries in this index */
-    private volatile int entries;
-
+    private final AtomicInteger entries;

Review Comment:
   We should not make any changes outside of the rename in this PR. Also, the 
method `incrementEntries` says:
   
   > // The caller is expected to hold `lock` when calling this method
   
   So, it is actually not incorrect.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org