satishd commented on code in PR #13213:
URL: https://github.com/apache/kafka/pull/13213#discussion_r1098698848
##########
storage/src/main/java/org/apache/kafka/storage/internals/log/AbstractIndex.java:
##########
@@ -64,8 +65,7 @@ private enum SearchResultType {
*/
private volatile int maxEntries;
/** The number of entries in this index */
- private volatile int entries;
-
+ private final AtomicInteger entries;
Review Comment:
I made this change as we were making minor changes when larger refactorings
are done in earlier PRs, and calling those minor changes in the PR.
Sure, we can keep this PR only for renames. But I do not think we should
have a contract for the caller to invoke in a lock because we have a volatile
primtive to be incremented. This can be discussed in another PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
