[GitHub] [kafka] divijvaidya commented on a diff in pull request #12590: KAFKA-7109: Close fetch sessions on close of consumer

[via GitHub]

divijvaidya commented on code in PR #12590:
URL: https://github.com/apache/kafka/pull/12590#discussion_r1100593799


##########
core/src/test/java/kafka/testkit/KafkaClusterTestKit.java:
##########
@@ -238,7 +238,7 @@ public KafkaClusterTestKit build() throws Exception {
                                 bootstrapMetadata);
                     } catch (Throwable e) {
                         log.error("Error creating controller {}", node.id(), 
e);
-                        Utils.swallow(log, "sharedServer.stopForController", 
() -> sharedServer.stopForController());
+                        Utils.swallow(log, "sharedServer.stopForController", 
() -> sharedServer.stopForController(), null);

Review Comment:
   ah! intended to do that. Have done it now.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org