vamossagar12 commented on code in PR #12802:
URL: https://github.com/apache/kafka/pull/12802#discussion_r1055570645
##########
connect/runtime/src/main/java/org/apache/kafka/connect/runtime/distributed/DistributedHerder.java:
##########
@@ -1658,11 +1659,20 @@ private void backoff(long ms) {
backoffRetries = BACKOFF_RETRIES;
}
- private void startAndStop(Collection<Callable<Void>> callables) {
+ // Visible for testing
+ void startAndStop(Collection<Callable<Void>> callables) {
try {
startAndStopExecutor.invokeAll(callables);
} catch (InterruptedException e) {
// ignore
+ } catch (RejectedExecutionException e) {
+ // Shutting down. Just log the exception
+ if (stopping.get()) {
+ log.debug("RejectedExecutionException thrown while herder is
shutting down. This could be " +
+ "because startAndStopExecutor is either already
shutdown or is full.");
Review Comment:
That's a good point. I didn't factor in the capacity part. Thanks for
pointing it out 👍
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
