mjsax commented on code in PR #13189:
URL: https://github.com/apache/kafka/pull/13189#discussion_r1102260418


##########
streams/src/main/java/org/apache/kafka/streams/state/internals/RocksDBVersionedStore.java:
##########
@@ -273,7 +290,41 @@ public void init(final StateStoreContext context, final 
StateStore root) {
 
     // VisibleForTesting
     void restoreBatch(final Collection<ConsumerRecord<byte[], byte[]>> 
records) {
-        throw new UnsupportedOperationException("not yet implemented");
+        // advance stream time to the max timestamp in the batch
+        for (final ConsumerRecord<byte[], byte[]> record : records) {
+            observedStreamTime = Math.max(observedStreamTime, 
record.timestamp());
+        }
+
+        final VersionedStoreClient<?> restoreClient = 
restoreWriteBuffer.getClient();

Review Comment:
   I see -- fair enough (in general, I am a fan on strong typing whenever 
possible, but it's ok I guess).



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to