mjsax commented on code in PR #13189:
URL: https://github.com/apache/kafka/pull/13189#discussion_r1102262205
##########
streams/src/test/java/org/apache/kafka/streams/state/internals/RocksDBVersionedStoreTest.java:
##########
@@ -383,6 +389,114 @@ public void shouldDistinguishEmptyAndNull() {
verifyTimestampedGetNullFromStore("k", SEGMENT_INTERVAL - 8);
}
+ @Test
+ public void shouldRestore() {
+ final List<DataRecord> records = new ArrayList<>();
+ records.add(new DataRecord("k", "vp20", SEGMENT_INTERVAL + 20));
+ records.add(new DataRecord("k", "vp10", SEGMENT_INTERVAL + 10));
+ records.add(new DataRecord("k", "vn10", SEGMENT_INTERVAL - 10));
+ records.add(new DataRecord("k", "vn2", SEGMENT_INTERVAL - 2));
+ records.add(new DataRecord("k", "vn1", SEGMENT_INTERVAL - 1));
+ records.add(new DataRecord("k", "vp1", SEGMENT_INTERVAL + 1));
+
+ store.restoreBatch(getChangelogRecords(records));
+
+ verifyGetValueFromStore("k", "vp20", SEGMENT_INTERVAL + 20);
+ verifyTimestampedGetValueFromStore("k", SEGMENT_INTERVAL + 30, "vp20",
SEGMENT_INTERVAL + 20);
+ verifyTimestampedGetValueFromStore("k", SEGMENT_INTERVAL + 15, "vp10",
SEGMENT_INTERVAL + 10);
+ verifyTimestampedGetValueFromStore("k", SEGMENT_INTERVAL + 5, "vp1",
SEGMENT_INTERVAL + 1);
+ verifyTimestampedGetValueFromStore("k", SEGMENT_INTERVAL, "vn1",
SEGMENT_INTERVAL - 1);
+ verifyTimestampedGetValueFromStore("k", SEGMENT_INTERVAL - 1, "vn1",
SEGMENT_INTERVAL - 1);
+ verifyTimestampedGetValueFromStore("k", SEGMENT_INTERVAL - 2, "vn2",
SEGMENT_INTERVAL - 2);
+ verifyTimestampedGetValueFromStore("k", SEGMENT_INTERVAL - 5, "vn10",
SEGMENT_INTERVAL - 10);
+ }
+
+ @Test
+ public void shouldRestoreWithNulls() {
+ final List<DataRecord> records = new ArrayList<>();
+ records.add(new DataRecord("k", null, SEGMENT_INTERVAL + 20));
+ records.add(new DataRecord("k", null, SEGMENT_INTERVAL - 1));
+ records.add(new DataRecord("k", null, SEGMENT_INTERVAL + 1));
+ records.add(new DataRecord("k", null, SEGMENT_INTERVAL - 10));
+ records.add(new DataRecord("k", null, SEGMENT_INTERVAL + 10));
+ records.add(new DataRecord("k", "vp5", SEGMENT_INTERVAL + 5));
+ records.add(new DataRecord("k", "vn5", SEGMENT_INTERVAL - 5));
+ records.add(new DataRecord("k", "vn6", SEGMENT_INTERVAL - 6));
+
+ store.restoreBatch(getChangelogRecords(records));
+
+ verifyGetNullFromStore("k");
+ verifyTimestampedGetNullFromStore("k", SEGMENT_INTERVAL + 30);
+ verifyTimestampedGetNullFromStore("k", SEGMENT_INTERVAL + 15);
+ verifyTimestampedGetValueFromStore("k", SEGMENT_INTERVAL + 6, "vp5",
SEGMENT_INTERVAL + 5);
+ verifyTimestampedGetNullFromStore("k", SEGMENT_INTERVAL + 2);
+ verifyTimestampedGetNullFromStore("k", SEGMENT_INTERVAL);
+ verifyTimestampedGetNullFromStore("k", SEGMENT_INTERVAL - 1);
+ verifyTimestampedGetValueFromStore("k", SEGMENT_INTERVAL - 5, "vn5",
SEGMENT_INTERVAL - 5);
+ verifyTimestampedGetValueFromStore("k", SEGMENT_INTERVAL - 6, "vn6",
SEGMENT_INTERVAL - 6);
+ verifyTimestampedGetNullFromStore("k", SEGMENT_INTERVAL - 8);
+ }
+
+ @Test
+ public void shouldRestoreWithNullsAndRepeatTimestamps() {
+ final List<DataRecord> records = new ArrayList<>();
+ records.add(new DataRecord("k", "to_be_replaced", SEGMENT_INTERVAL +
20));
+ records.add(new DataRecord("k", null, SEGMENT_INTERVAL - 10));
+ records.add(new DataRecord("k", "to_be_replaced", SEGMENT_INTERVAL -
10));
+ records.add(new DataRecord("k", null, SEGMENT_INTERVAL - 10));
+ records.add(new DataRecord("k", "to_be_replaced", SEGMENT_INTERVAL -
1));
+ records.add(new DataRecord("k", "to_be_replaced", SEGMENT_INTERVAL +
1));
+ records.add(new DataRecord("k", null, SEGMENT_INTERVAL - 1));
+ records.add(new DataRecord("k", null, SEGMENT_INTERVAL + 1));
+ records.add(new DataRecord("k", null, SEGMENT_INTERVAL + 10));
+ records.add(new DataRecord("k", null, SEGMENT_INTERVAL + 5));
+ records.add(new DataRecord("k", "vp5", SEGMENT_INTERVAL + 5));
+ records.add(new DataRecord("k", "to_be_replaced", SEGMENT_INTERVAL -
5));
+ records.add(new DataRecord("k", "vn5", SEGMENT_INTERVAL - 5));
+ records.add(new DataRecord("k", null, SEGMENT_INTERVAL + 20));
+ records.add(new DataRecord("k", null, SEGMENT_INTERVAL + 20));
+ records.add(new DataRecord("k", "vn6", SEGMENT_INTERVAL - 6));
Review Comment:
Similar to N/5 -- hard to keep track without writing it down. Can we add
some comments?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
