gharris1727 commented on code in PR #13291:
URL: https://github.com/apache/kafka/pull/13291#discussion_r1117488058
##########
connect/runtime/src/test/java/org/apache/kafka/connect/integration/ExactlyOnceSourceIntegrationTest.java:
##########
@@ -266,6 +267,7 @@ public void testPollBoundary() throws Exception {
props.put(NAME_CONFIG, CONNECTOR_NAME);
props.put(TRANSACTION_BOUNDARY_CONFIG, POLL.toString());
props.put(MESSAGES_PER_POLL_CONFIG, Integer.toString(recordsProduced));
+ props.put(THROUGHPUT_CONFIG, Integer.toString(recordsProduced));
Review Comment:
Since the result of Integer.toString(100) and Long.toString(100L) are the
same, I don't think this necessary.
The reason I re-used the same variable was because I wanted to keep the
runtime of the test constant. If there were two variables, someone could tune
one while holding the other constant until the test timed out.
I agree that `recordsProduced` is a poor name, because this test produces
many more records than that under normal conditions. Do you have a better name
in mind?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
