edoardocomar commented on code in PR #13291:
URL: https://github.com/apache/kafka/pull/13291#discussion_r1118569732
##########
connect/runtime/src/test/java/org/apache/kafka/connect/integration/ExactlyOnceSourceIntegrationTest.java:
##########
@@ -266,6 +267,7 @@ public void testPollBoundary() throws Exception {
props.put(NAME_CONFIG, CONNECTOR_NAME);
props.put(TRANSACTION_BOUNDARY_CONFIG, POLL.toString());
props.put(MESSAGES_PER_POLL_CONFIG, Integer.toString(recordsProduced));
+ props.put(THROUGHPUT_CONFIG, Integer.toString(recordsProduced));
Review Comment:
Again, it may not be *necessary* to use Long instead of Integer but it helps.
And using two variables instead of one, although with related values is
again helping readability.
Reusing the same one is something that makes me stop and think "why...?"
So having a 2nd variable e.g. like
`long throughput_msgs_sec = recordsProduced / 2L;`
would be my preference (and a short line comment for it) e.g.
// need to limit actual records.count() to avoid OOM
##########
connect/runtime/src/test/java/org/apache/kafka/connect/integration/ExactlyOnceSourceIntegrationTest.java:
##########
@@ -266,6 +267,7 @@ public void testPollBoundary() throws Exception {
props.put(NAME_CONFIG, CONNECTOR_NAME);
props.put(TRANSACTION_BOUNDARY_CONFIG, POLL.toString());
props.put(MESSAGES_PER_POLL_CONFIG, Integer.toString(recordsProduced));
+ props.put(THROUGHPUT_CONFIG, Integer.toString(recordsProduced));
Review Comment:
Again, it may not be *necessary* to use Long instead of Integer but it helps.
And using two variables instead of one, although with related values is
again helping readability.
Reusing the same one is something that makes me stop and think "why...?"
So having a 2nd variable e.g. like
`long throughput_msgs_sec = recordsProduced / 2L;`
would be my preference (and a short line comment for it) e.g.
`// need to limit actual records.count() to avoid OOM`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
