C0urante commented on code in PR #13193:
URL: https://github.com/apache/kafka/pull/13193#discussion_r1097934299
##########
connect/runtime/src/main/java/org/apache/kafka/connect/runtime/ConnectMetricsRegistry.java:
##########
@@ -187,7 +187,8 @@ public ConnectMetricsRegistry(Set<String> tags) {
sourceRecordWriteTotal = createTemplate("source-record-write-total",
SOURCE_TASK_GROUP_NAME,
"The number of records output
from the transformations and written to Kafka for this" +
" task belonging to the named
source connector in this worker, since the task was " +
- "last restarted.",
+ "last restarted. This is after
transformations are applied and excludes any records " +
+ "filtered out by the
transformations.",
Review Comment:
Is this clarification necessary? The description already includes the phrase
"records output from the transformations and written to Kafka".
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
